Add support for MQTT pver SSL and update to attemp disconnects and extra loggin on mqtt failures #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for a local mqtt broke that uses ssl. Allow user to add in their ca,crt file and if exists use SSL for mqtt uploads.
|
Thanks for this. A few additions:
|
Added new mqtt parameter to the config_template for ca.crt file location and added check for ca.crt parameter variable incase it is not there in user's config
When low disk space detected try to upload the readings to free up the disk space. On Boot sleep for 0.5 seconds at start.
dave-ct
changed the title
Have monitored different errors from MQTT during upload after connection. In the event of an OSError or IndexError try to disconnect MQTT to see if it prevents hangs.
|
Added a couple more updates here, still testing to see if they work. |
If edit made in pycharm ignore .idea/ structure
|
Thank you for the additions. Any chance you can raise the logging change as a separate PR to this please? Makes it easier on my end to evaluate and approve the changes. |
This reverts commit c902806.
|
@ZodiusInfuser have reverted from here and created new pull request #128 Will also clean this pull request so it just relates to mqtt |
dave-ct
changed the title
Corrected logging in mqtt update as missing import on error
|
Thanks for tidying this up. There's a few things from a code standpoint that I'd like to do, but they can be done after this is merged in 🙂 |
|
Specifically, turn that exception logging line into a neater function call, and correct a few typos in the comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a local mqtt broke that uses ssl. Allow user to add in their ca,crt file and if exists use SSL for mqtt uploads.
Relates to issue #122